UberFix v1.02

Ptarth

Join Date 02/2007

+90

UberFix v1.02

UberFix

The UberFix is a compilation of bugfixes for Demigods version 1.2. The patches incorporated into the mod
are listed below along with the creator of the patch.

Download:

v1.02

Installer format: www.box.net (Recommended Download)

filesize: 334,609 bytes

MD5 Checksum: 5322667e9be4dbd0fc9cb44823a6dc81

Source Code: www.box.net

Old Versions

v1.01

Installer format: www.box.net

filesize: 322,544 bytes (Downloaded 223 times)

Source Code: www.box.net

v1.00

Downloaded 178 times

zip format: 16.5 KB v1.00 Mediafire v1.00 Box.net

exe format: 301.2KB v1.00 Box.net

Currently Included Patches

Uberfix 1.02

Lord Erebus Poisoned Blood Potion Fix by Ptarth
- Poisoned Blood Potions can no longer be used by Lord Erebus to farm himself. He and his teammates treat his Poisoned Blood Potions as regular potions now.
Oculus Electrocution Fix by Ptarth
- Health and Mana regeneration are now correctly stopped.
Torch Bearer Projectile slowdown Fix by Ptarth
- Toch Bearer's fireballs and fireblasts now correctly accelerate to maximum speed when their target moves a great distance. This includes his Fireball Ability.
Unclean Beast Ooze Suicide Fix by Ptarth
- Ooze now correctly ends when the Unclean Beast is low on Health.
Oculus Sacrifice Fix by Ptarth
- Sacrifice now will heal allied units.
Unclean Beast Post Mortem Plague Conflict Fix by Exxcentric
- Plague I and II no longer remove the Post Mortem death effect.
Rook Move Attack Fix by Ptarth
- Rook now attacks while moving correctly.

UberFix 1.01

Lord Erebus Mist Form Fix by Ptarth
- updated to end when mana drops below 125.
ZikFix (Zikurat Tower Fix) by mrappard
- The Dark side towers on Zikurat while playing Conquest now spawn correctly, instead of at warscore 6.
Orb of Veiled Storms Fix by Ptarth (bug reported by awuffleablehedgie)
- The Orb of Veiled Storms now deals ArmorImmune damage like every other demigod ability and weapon ability (except for the Doomspite Grips and Girdle of Giants, which have a cleave attack).

UberFix 1.00

Minion +hp Fix by Ptarth
- Minions summoned by Demigods Generals [Sedna, Lord Erebus, Oak, Queen of Thorns, Oculus] with +minion hp items now have the correct health
Oculus Brain Storm Fix by Ptarth
- Brain Storm now has a visual effect at all levels, instead of only when Oculus has Mental Agility
- Brain Storm now removes debuffs on targeted unit as specified by the rollover tooltip text
Queen of Thorns Attack Animation Glitch Fix by Ptarth
- Reduced the lifetime of the QoT's root attack animation to make the animation look better.
- This is only a cosmetic change.
Oculus Lightning Ball Summons Fix by Ptarth
- Lightning Balls will no longer summon in map void space.
Oculus Lightning Blast Fix by Ptarth
- Lightning Blast now occurs at the origin of the target instead of the origin of the unit that procs the effect.
Missing Oculus Shield Effect Fix by Ptarth
- Oculus now has a visible Shield effect.
Heart of Life and Wings of the Seraphim Healing ends effect Fix by Ptarth (awuffleablehedgie provided starter code)
- The Heart of Life and Wings of Seraphim no longer stop their regeneration effects when the user is healed.
Parasite Egg and Sludge Slinger Partial Fix by Ptarth
- Changed the Parasite Egg and Sludge Slinger so they can be used, although it isn't perfect.

Current Buglist (Todo list: Verified and replicatable)

Rook Shoulder weapons having target locking issues
- I thought I had something to fix it. However, I'm having problems replicating the effect to test it.
Fix the skill queue.
- Eg, if you tell a UB to grasp he tries to get into melee range and execute the grasp. If you tell him to spit, then it gets thrown to the back of the skill queue and he doesn't spit, he continues to follow like an r'tard. To fix it you have to issue a move command, then spit.
- AbilityTask.lua has the functions related to this. There are many interesting things in it.
- After finishing a command the demigod reverts to an attack/move order if previously moving towards a target
AA targeting issues
- Like how Oak frequently swings with his Axe and does no damage or how Sedna will stand by a target without attacking
- This may be linked to the Rook Shoulder weapon problem or the command queue
- (http://forums.demigodthegame.com/356419)
- Demon Assassin stops auto-attack after warp strike. It should continue to attack the locked target... this would be natural.
Rollover Data Error on flag tooltip while being captured behind fog of war.
Demigods do not resume auto-attack immediately or change targets after using an ability.
UB Post Mortem damage does not count as UB damage for the purpose of awarding gold.
Move order is canceled when using effects (http://forums.demigodthegame.com/356694). The move order is turned into an auto-attack order.
Inaccurate health bar on zoom in (http://forums.demigodthegame.com/356347)
Language for engine messages (xxx has left, xxx has joined...) in game lobby uses the hosts language setting (this should be the users language setting): my russian is a bit rusty!
Torchbearer respawns in Ice mode by default. This should be the last used mode (Fire/Ice)! Same for QoT.
Queuing to grab a potion and then being Foul Grasped while picking up the potion and then UB getting Shadow Swaps allows you to pick up the potion instantly as long as you have contiguous line of sight. I've been able to do this roughly 25 in-game yards away.
When a demigod switches primary weapon the window information doesn't update properly (mainly a QoT issue)
1. This is a visual glitch, the weapon does change, but the window does not update correctly.
Oculus cannot autoattack directly beneath him

Bugs Requiring Research List (requires verification and a reliable replication method)

Light/Dark capping all flags creates "Invalid Game State" error (http://forums.demigodthegame.com/362132)
1. This happens enough to know that there is an issue, but without a way to replicate it reliably it is beyond me to fix
Torch Bearer's stat progression for PermaFrost Movement Debuff is 3%/10%/15%. It should probably be 5%/10%/15%
"War Score" display at each teams' citadel is incorrect.
- It shows the average of the two teams' warscore, it really should show just yours.
- The citadels look to upgrade correctly.
Minions still get stuck in citadels
- Need a map person to look into hedgie's proposed fix idea
Oculus's Ball Lightnings attack animation sometimes sticks with permanent bolt from minion to target.
Oculus's Chain Lightning effect sticks until his or target's death if target teleports during cast.
Oculus sometimes becomes unresponsive after using Blast Off.
Sedna's Silence debuff never expires under certain circumstances.
Oculus moves very slowly when selected with Ball Lightnings.
Pathing issues on Prison
Selling Monk idols sometimes destroy summoning button
- To replicate: Summon Monks, Sell Monks (while idol is recharging), Buy a different type of idol (siege archer or warrior, possibly any other item too), Buy new Monk Idol. I can't replicate this any more for some reason.

Current Unfixable Errors (Can't do list)

Sedna's low quality Silence effect causes speakers to silence
1. Unfixable since we can't access and change the sound files
2. Setting sound quality to medium fixes this for most people.
Ping times periodically spike in-game (despite sufficient upload bandwidth).
1. This is not handleable within lua
Multi-game achievements fail to record progress properly.
1. This is controlled by Impulse
Overlay friend chat buttons constantly reappear.
1. Controlled by Impulse
Game result stats include players who joined and left lobby before match start.
1. Controlled by Impulse?
demigods.exe is looking for version 1.20.211 but is version 1.20.214 with the last patch
1. GPG compiles the exe
warning: 00:03:04: Granny: FileReading (c:\Work\forge\main\code\src\libs\granny\granny_file_info.cpp(152): File has run-time type tag of 0x8000002d, which doesn't match this version of Granny (0x80000026). Automatic conversion will be attempted.)
info: 00:03:04: Total Material Count: 24 Total Mesh Count: 24
info: 00:03:05: Can't find texture "/env/common/layers/none_normal.dds" -- trying fallback.
1. Internal and Granny related, all GPG accessible only
Oculus Stun Animation does not loop fluidly
1. The animations are scripted in Granny which we don't have access to.
Demon Assassin's movie on the character select screen was filmed using the wrong skin.
1. The movie was made using Granny and Bink, we don't have access to Granny
Assorted replay playback issues
Game result stats include players who joined and left lobby before match start.

Current Nonbugs (Feature List)

Mana/Health loss on item drop (http://forums.demigodthegame.com/360939)
- Working as intended I believe
Oak's Shield can be interrupted
- This is most likely a lag effect
Scroll of Restoration doesn't cure stuns
- The scroll only affects debuffs, not stuns

Bugs Fixed by Previous Official Patches (SD & GPG fixed it list)(not complete, just ones that come up)

Match ending while dead results in "wind" effect persisting until game is closed.
Sound looping issue (http://forums.demigodthegame.com/356935).

Current Potential Additions to the BugFix (Addition list)
1. SkillInfoMod
2. AIMod by Peppe

Current Semi-Active Project Members

Ptarth - guy who does stuff

awuffleablehedgie - guy who finds bugs

UhelligGudn - new guy with lots of energy

Plea to Community

If we want Stardock and Gas Powered Games to increase their support of Demigods, we need to demonstrate our commitment and our willingness to support it. If we want to accomplish anything worthwhile to demonstrate our commitment, we need to work together. If you have time, please consider helping out. Every little bit helps.

Locked Post +12 Karma

Advanced Search

Watch this post

Do not email me updates for this post Email me updates for this post

Successfully updated karma reason!

Orcun-
GM-morpheas768
Flexscan123
GM-morpheas768
zenjiro
Wimmetje
Ke5trel
Teseer
Nucleus Accumbens
Spooky__
and 2 more...

This makes Occ OP...

Successfully updated karma reason!

Quoting Maccilia,

reply 401

This makes Occ OP...

It is not the job of this fix to maintain balance but to implement the game as it is supposed to work. If this ruins the balance then additional balancing will be required in a separate fix. Leaving bugs in the game just because they indirectly cause balance is a fairy silly.

Successfully updated karma reason!

Quoting pacov,

reply 400

I'm really glad you guys are doing all this work. Thanks again!

I'm glad too. I also want to thank you

Great work Ptarth

"Successful Troll is Successful"

Successfully updated karma reason!

Quoting Ptarth,

reply 399

The previous code snippet was from platoon.lua. However, changing it and adding LOG statements didn't seem to do anything. I'm not sure if that means the code isn't being run (platoon.lua does load in the log after I change it) or if it is being run, but isn't what is controlling the movements.

I tried commenting out entire portions of this file to no real effect. I had no luck in AbilityTask.lua either, where I hoped perhaps to hook into some more generic (as minions and demigods share quite a bit of code) functionality to perhaps fix how this works, no luck. No time to look much further right now unfortunately.

Successfully updated karma reason!

Grrrr The poison blood and ooze suicide ARE balance fixes

UB Suicide
LE Poison Blood
Why I believe these are balance changes and not bug fixes.

UB suicide is intended as a game mechanic as it is implemented as such in the game. The unfortunate side effect is that UB can escape giving up a kill if his Ooze happens to be the damage effect that kills him.

The proper way to handle this would be the way every other death works in this game, with the exception of awarding a kill to UB. So, any opposing DGs who qualify for an assist when UB suicides himself should infact get such a reward. Much like what happens when you attempt to save a kill by suiciding yourself into damage not originating from an opposing DemiGod. (such as a tower or creep)

Poison Blood is intended as a game mecahnic not only to damage enemy units, but to ensure proper balance is maintained for giving LE a higher regeneration rate. Tactically speaking, it also gives LE the option of not leaving a potential 3000HP healing potion laying around to be used at a later date against him. Considering his skills are well suited for striking behind enemy lines, one could also argue this is an intentional game design decision. The unfortunate side effect is that LE can kill himself and be awarded a kill bonus in this manner, which is clearly not intended. It should be handled in the same manner as any other deliberate attempt to escape giving up a kill from a non-demigod source. LE dies, is not awarded a kill for himself, and appropriate awards for assists are given out. As for damaging team mates, this is clearly intended as it is described this way in the skill description. One could also argue that it is a "flavor" for the forces of darkness, in that a selfish and uncooperative vampire lord would gladly see a teammate die for his own gain.

So, Team mates should be able to die from friendly LE poison blood potion and LE should be awarded a kill for that effort. Although there is a gold benefit, there is also a penalty in that your teammate is out of commission for several seconds which is more undesirable then free gold later in the game.

Oh, and thanks... it's not like I don't appreciate the work you do and I do use UberFix all the time when I can... I just have to question some things to keep you honest.

edited: so as to not hurt anyones feelings.

Successfully updated karma reason!

Step 1: Fix Bugs

Step 2: ?????

Step 3: Re-balance game with a separate balance patch once game is bug free.

How many times must it be explained that just because something indirectly may or may not balance the game does not make it any less of a bug. There is a big difference between what is a bug and what is a balance fix. A bug may or may not affect balance, but a balance fix is not a bug. This patch aims to fix all BUGS regardless of their effect on balance. Balance can be sorted out after (or even in parallel) but this patch is purely for BUG fixes.

Please learn the difference.

Successfully updated karma reason!

Hostile post removed by myself.

Successfully updated karma reason!

All bugfixes are balance fixes. This is true. They change the way the game currently works.

However, bugfixing is not making changes for the purpose of adjusting balance. Bugfixing is making changes to make the code behave more like it was intended to behave. As previously discussed and demonstrated in great detail, both the LE poisoned blood potion fix and UB suicide action are the result of faulty programming logic, not of intent.

Now, if you wish to consider something troublesome, how about this hypothetical scenario:

Let's say that Oculus has an ability that claims to grant an attack speed boost. Let's say there is no sign of an attack speed boost in the code. Let's further say that communication with GPG reveals that the ability was intended to grant an attack speed boost, but there wasn't sufficient time to balance test it before release. Now, given all of these hypotheticals, what should be done with this ability?

Successfully updated karma reason!

Hostile post removed by myself.

Successfully updated karma reason!

Thread Rules

No Name calling
No spamming
Violations of these rules will result in no official repercussions against the violators. I have no power, and this is not an official project.
Violations of these rules may result in a lack of interest in continuing the Uberfix fixes. I don't have to put up with things that are more troublesome than they are worth.

Project Rules

All efforts to facilitate progress in this project will be met with roughly equal effort.
If you put in work, I'll put in work.
If you look into an issue, I'll give you everything I have on it and everything I know that's related.
if you tldr, I'll tldr.

Re: Suicide

I concur that suicide is not an accidental effect.

However, I disagree with your assessment that suicide due to Ooze is intentional. If you disagree please revist my previous discussion of this bug, and the code I posted. Please form your rebuttals using code.

Re: Poisoned Blood

I will grant you that this case is more difficult. Please tell me where the following logic is wrong.

Allies are not meant to damage each other.
Death effects are meant to give bonuses to your team, or penalties to your enemies.
The logic for Poisoned Blood was not developed fully, this resulted in Lord Erebus being able to farm himself for infinite gold.
Allies have access to potions dropped by death a few seconds earlier than enemies.

Thus I concluded that the Poison Blood logic should be developed further. In line with the idea that dying allies enhance their team and that potion drops are beneficial to the team, this suggests that Poisoned Blood Potions should also have this effect.

Successfully updated karma reason!

Hostile post removed by myself.

Successfully updated karma reason!

pacov

Join Date 02/2008

+183

Hey - good news - Sorian is working on some fixes (no idea what). see his blog for details, but SD apparently sent them a list of bug fixes they want. I think Sorian is working on it today and yesterday (expecting to send a new build to SD possibly today)... no idea when we'll see an actual release, though.

http://soriandev.blogspot.com/2010/05/patch-114-is-live.html

Successfully updated karma reason!

NVM, pavoc added the link to Sorian's blog in some weird cosmic undulation of time/space relative to this post.

Successfully updated karma reason!

re:Sorian's new Fixes

I saw that too. I sent in a request if they would give me a heads up on what is being looked at. Hopefully they will answer my petition so we can see where we stand.

re: People's behavior

My listed rules are for everyone, not just those that are disagreeing with my approach. However, I will grant you that I'm less offended by people that tell others to sod off than by people who tell me to sod off. There is a direct relationship with my patience with people who have put time and effort into fixing bugs versus those who might be trolling just for the lols. If you put hours into writing up a fix I'm willing to cut you some slack when it comes to interpretations. If you spend 30 seconds to say, "You = wrong", I'm not willing to cut you very much slack. On the other hand if you spend 20 minutes writing and rewriting a post, I'm willing to take it as a sign of good faith.

Also, since I'm lecturing. Just because someone else is acting poorly doesn't give anyone the right to act poorly. If this was the case we'd all be taking our friend hunting and accidentally shooting them in the face (e.g., Vice President Cheney).

re: Lord Orion's Objections

I didn't post in detail because the thread history has tons of code and argument in it. Writing up all of this and searching out code fragment takes time and effort. I don't feel that is it a good use of my time to do this if my readers are going to respond with less than 20 characters. I would request that you go back and reread my posts on the subject. However, given the work you put into your response, I'll honor you with a similar effort, and list some reminder highlights.

re: Ooze suicide

The suicide code is not part of Ooze code. Suicide is a side effect of obtaining a health value less than 1 and having yourself deal the damage that reduces you to this health value. Lord Erebus's Blood potion is another way to achieve this effect, however the source of the damage is different so the message is also different. Given that there are multiple ways to achieve the same sort of event (health < 1) and the code you are referring to (Ooze and Suicide) are in different locations without any referrals to the other, I disagree with your claim. Again I also request you reread the previous discussions for more details.

re: Poisoned Blood

Drink a potion is not a direct effect on a team mate from another.
1. I disagree. If your teammate drops a health potion for you, you gain life.
2. Likewise if your teammate dies and drops a health potion for you, you gain life.
3. I fail to see how this is not a direct effect on your teammates.
However, looking at the one other comparable mechanic in the game, would you saythat landmines that damage your enemy should explode and heal your allies?
1. I do not concede that land mines are a comparable mechanic.
  1. Land mines cannot be triggered by your allies, on purpose or by accident.
  2. Land mines do not mimic a positive buff effect.
  3. You do not receive splash damage from allied land mines.
2. I'm not sure there is a perfect comparable effect, but something that duplicates the current potion effect is Blood Mist
  1. When enemies are in Erebus's Mist while he has Blood Mist they lose life.
  2. When allies are in Erebus's Mist wihle he has Blood Mist they have life drain or bonus health regeneration. (I don't believe it is necessary to confirm which it has at this point)
The exsisting game mechanic is to not reward your team for taking poison blood. (it is poison).
1. Poison is flavor text.
2. It does not define the effect of the ability.
3. Flavor arguments can be used to validate anything.
  1. Unnecessary case in point: Rook's Smash. How exactly do allied Demigod avoid the AOE damage of a massive hammer falling upon them.
Your proposed game mehanic is to allow your team mates to heal 3000 HPs instead of take damage.
1. My previous proposals were to either give allies 0 health or regular potion heals. After discussion and consideration treating the potion like a normal potion of its rank was selected as the most appropriate outcome.
The other, similar exsisting game mechanic does not reward your team for being careless. (it points out where invisible mines are, and when you step on them does not reward you for doing so)
1. I disagree again that mines are a valid comparison.

Successfully updated karma reason!

It should be implemented. Please. If you want to make it separate from Uber to prevent tainting the pure bug fixes that's fine, but rest easy that no one will be upset to see an Oculus with viable auto-attacks

Successfully updated karma reason!

Quoting Ke5trel,

reply 415

Quoting Maccilia,

reply 401

This makes Occ OP...

This makes me giggle.

Yes. I used giggle.

I do think there should be a balance fix. There was one at one point, but I didn't get into it that much. I think that interest fell off in such a mod. I do intend to work on one when I have time. Currently I'm busy making people angry by changing the color of the QoT.

Successfully updated karma reason!

re:Sorian's new Fixes

I saw that too. I sent in a request if they would give me a heads up on what is being looked at. Hopefully they will answer my petition so we can see where we stand.

Will you try to keep us update on if they get back to you?
And thanks for all your awesome work

Successfully updated karma reason!

Hostile post removed by myself.

Successfully updated karma reason!

Hostile post removed by myself.

Successfully updated karma reason!

Quoting LORD-ORION,

reply 418

Hostile post removed by myself.

Hostile post removed by LORD-ORION

"Successful Troll is Successful"

Successfully updated karma reason!

As I see it, Erebus' potion would normally heal his allies if they took it, if he gets the poison blood ability, not only do his enemies now have to avoid potions as they may be poisonous, now his allies have to be careful also. It's not that fixing this bug will give allies a magical 3000 unbalanced heal, it will give them the heal already decided upon and balanced that everyone else in the game already drops. Fixing this bug will only remove the negative side-effect of this ability. There is no other ability in the game that lets you deal friendly damage, this is not a realistic simulation so the argument that poisoned blood should hurt everyone is void. TB's giant rings of fire should hurt everyone, or rooks hammer slam, or any other AOE or splash ability in the game doesn't do friendly damage.

Also, a balance mod is going to be dangerous waters, you can already see how worked up people get in this thread, heaven forbid the arguments over whether it should be a 1% or a 2% buff/debuff to something.

Successfully updated karma reason!

Quoting UhelligGudn,

reply 421

You missed the obvious balance scenario. LE decides he is going to play risky and zip in and out of the enemy's towers to pursue targets. This might kill him. He takes poison blood so he does not leave a 30oo hitpoint treat at the enemy towers if he dies by tower fire after a kill. Now not only can the enemy not take the blood, but his allies have a 3000 hp heal in hostile territory.

I cannot believe you are arguing it as a bug fix when the skill description itself says it will harm "whoever" drinks it.

Successfully updated karma reason!

Descriptions are troublesome to interpret at times.

Consider the following:

Gloves that "drain" mana. Hedgie was nearly willing to kill when he found out it doesn't grant the user the mana drained.
Towers of Light do not give credit for kills to the Rook. This isn't in the help text.
Soul Power Buff for Oak
Regulus mines do not give Gold under certain circumstances
Oculus Ball Lightning's claim to give a attack speed buff to allies nearby.

The problems with balance arguments are that as soon as you ask the question, is this balanced, you have entered into the realm of balancing. I'm not sure if it is unavoidable in this case. If you'd like I'd encourage you to start and maintain a thread in the general discussion about the issue and try to reach a general consensus with the community.

Also, the Potions are 750 for Poison Blood I and 3000 for Poison Blood II. The same for the appropriate level potion that it masquerades as.

As for your balance question, I'm not going into the particulars because I'm sure we could argue about balance all day. However, I will suggest the following:

Strategies based on dying are generally very bad.
The frequency of Lord Erebus deaths in a game are very low.
The frequency of a Poison Potion drop making a difference in a game, are even lower.

Successfully updated karma reason!

Sorry to put this thread bit off topic but so far ooze is the only skill that allow to kill yourself and since such option exist I belive that what it was intented by programers.

I do not agree that it dosnt give assist money to whoever was fighting beast before but 'xxx just suicided' in my opinion was made for beast only (since there is no other way to bring your hp below 1 for any other demigods)

Erebus killing himself with his own blood is obvius mistake. However his blood shouldnt heal anyone especially himself.

In my opinion it should give a suicide and assists to whoever he fought.

But again with no word from GPG it is a matter of opinion and since its ur uberfix u can do whatever u wish and we should be thankfull that u spend time lisening to our opinions

Successfully updated karma reason!

awuffleablehedgie

Join Date 04/2009

+60

Towers of light award kill money to Rook. Same as mines and other "minions".

Successfully updated karma reason!